Ticket #20 (closed defect: wontfix)

Opened 2 years ago

Last modified 5 months ago

roster.remove_item not compliant

Reported by: roberto Owned by: jajcus
Priority: minor Component: pyxmpp
Keywords: roster remove_item Cc:

Description

when using function roster.add_item:

- a string jid - a roster item

may be passed. instead, when using function roster.remove_item:

- only a JID object can be passed.

=> roster.remove_item should comply and accept:

- a string jid or - a roster item.

r.

Change History

Changed 5 months ago by jajcus

  • status changed from new to assigned

Changed 5 months ago by jajcus

  • status changed from assigned to closed
  • resolution set to wontfix

add_item() accepts RosterItem?() object as more than a JID is needed to add a full roster entry (roster entry is not just a JID). remove_item() only needs an identifier of an existing roster item to remove. And JID is the natural primary key of the roster. Making remove_item() accept RosterItem?() would be only unnecessary complication of the code. And doing it right (with changing argument name) would break the API too. There is no need for these two methods to be symmetrical.

Note: See TracTickets for help on using tickets.